Skip to content

feat: support user guilds #10995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

feat: support user guilds #10995

merged 1 commit into from
Jul 16, 2025

Conversation

@sdanialraza
Copy link
Member

@sdanialraza sdanialraza commented Jul 16, 2025

Please describe the changes this PR makes and why it should be merged:
Backports #10962

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@sdanialraza sdanialraza added this to the discord.js 14.22.0 milestone Jul 16, 2025
@sdanialraza sdanialraza requested review from a team as code owners July 16, 2025 16:18
@sdanialraza sdanialraza requested review from ckohen and removed request for a team July 16, 2025 16:18
@sdanialraza sdanialraza requested a review from Jiralite July 16, 2025 16:18
@sdanialraza sdanialraza requested review from SpaceEEC and removed request for a team July 16, 2025 16:18
@vercel
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jul 16, 2025 4:18pm
discord-js-guide ⬜️ Ignored (Inspect) Jul 16, 2025 4:18pm

@codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.60%. Comparing base (a271e9b) to head (43ddc19).
Report is 3 commits behind head on v14.

Additional details and impacted files 
@@            Coverage Diff             @@
##              v14   #10995      +/-   ##
==========================================
+ Coverage   35.59%   35.60%   +0.01%     
==========================================
  Files         228      228              
  Lines       14312    14315       +3     
  Branches     1259     1260       +1     
==========================================
+ Hits         5094     5097       +3     
  Misses       9174     9174              
  Partials       44       44
Flag Coverage Δ
proxy 66.27% <ø> (ø)
rest 88.14% <100.00%> (+0.03%) ⬆️
ws 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Jul 16, 2025
Qjuh
Qjuh approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in total LGTM

@sdanialraza sdanialraza merged commit baa08b8 into v14 Jul 16, 2025
27 checks passed
@sdanialraza sdanialraza deleted the feat/support-user-guilds branch July 16, 2025 20:27
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/rest

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/rest

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/rest

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/rest

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/rest

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

api support backport packages:discord.js packages:rest semver:minor

Projects

discord.js
Archived in project

Milestone

discord.js 14.22.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sdanialraza @Jiralite @Qjuh